#909 closed defect (fixed)

Message saying that we couldn't find bin/tahoe in test_runner.py should say where we looked

Reported by: davidsarah Owned by: davidsarah
Priority: major Milestone: 1.6.0
Component: unknown Version: 1.5.0
Keywords: test error cleanup Cc:
Launchpad Bug:


Several of the tests in source:src/allmydata/test/test_runner.py can be skipped if bin/tahoe isn't found, but it can be time-consuming to diagnose why. The attached message says where we looked for it, and gives a hint as to what might be wrong.

Attachments (1)

cannot-find-bin-tahoe.darcspatch.txt (42.9 KB) - added by davidsarah at 2010-01-16T20:55:37Z.
Message saying that we couldn't find bin/tahoe should say where we looked

Download all attachments as: .zip

Change History (8)

Changed at 2010-01-16T20:55:37Z by davidsarah

Message saying that we couldn't find bin/tahoe should say where we looked

comment:1 Changed at 2010-01-16T20:59:12Z by davidsarah

  • Keywords cleanup added

The patch also factors out some duplicated code.

Note that there's a slight behaviour change for test_baddir -- it uses tahoe start and tahoe stop, so it should be skipped if we can't daemonize. The test was working, but I don't know why and I think it was bogus.

comment:2 Changed at 2010-01-16T20:59:27Z by davidsarah

  • Keywords review-needed added

comment:3 Changed at 2010-01-16T21:01:03Z by davidsarah

  • Owner changed from nobody to davidsarah

comment:4 Changed at 2010-01-16T21:01:10Z by davidsarah

  • Status changed from new to assigned

comment:5 Changed at 2010-01-26T04:59:50Z by zooko

  • Resolution set to fixed
  • Status changed from assigned to closed

Looks good, thanks! Applied as 174d3566923a37b5.

comment:6 Changed at 2010-01-26T15:04:31Z by zooko

  • Milestone changed from undecided to 1.6.0

comment:7 Changed at 2010-01-29T20:53:59Z by davidsarah

  • Keywords review-needed removed
Note: See TracTickets for help on using tickets.