Opened at 2010-01-27T18:49:55Z
Closed at 2011-10-26T06:53:11Z
#930 closed defect (fixed)
switch from figleaf to coverage.py
| Reported by: | zooko | Owned by: | zooko |
|---|---|---|---|
| Priority: | major | Milestone: | soon (release n/a) |
| Component: | dev-infrastructure | Version: | 1.5.0 |
| Keywords: | testing | Cc: | |
| Launchpad Bug: |
Description
We have several problems using figleaf: #109, #387, #623, #810.
We opened an issue on the figleaf tracker and I email the figleaf maintainer, Titus Brown, a few months ago but so far no response: http://github.com/ctb/figleaf/issues .
Ned Batchelder's coverage.py appears to be actively maintained: http://nedbatchelder.com/code/coverage/
Maybe someone should explore whether we can solve our four issues more easily with coverage.py than with figleaf.
Attachments (1)
Change History (9)
comment:1 Changed at 2010-01-27T23:13:42Z by zooko
- Milestone changed from undecided to 1.7.0
comment:2 Changed at 2010-01-28T07:57:37Z by warner
- Owner changed from somebody to warner
- Status changed from new to assigned
- Summary changed from switch from figleaf to coverage.py? to switch from figleaf to coverage.py
Changed at 2010-01-28T18:38:17Z by warner
comment:3 Changed at 2010-01-28T18:39:26Z by warner
there's a patch to implement the switch: it removes figleaf entirely, and adds coverage.py equivalents. It includes a basic text report, and elisp annotation. The HTML report is still the basic coverage.py version, though, which means it's lacking lines-uncovered.. I'll work on that next.
comment:4 Changed at 2010-02-22T20:28:09Z by zooko
The patch Brian committed is 880f824103357172. I guess Brian will close this ticket after he makes it report on lines-uncovered.
comment:5 Changed at 2010-05-08T20:30:08Z by zooko
- Owner changed from warner to zooko
- Status changed from assigned to new
comment:6 Changed at 2010-05-08T20:30:16Z by zooko
- Status changed from new to assigned
comment:7 Changed at 2010-05-16T23:42:43Z by zooko
- Milestone changed from 1.7.0 to soon (release n/a)
coverage.py and trialcoverage and setuptools_trial play well together. Buildbots are running those tools. More doc and bigfixes and so on are coming..
comment:8 Changed at 2011-10-26T06:53:11Z by warner
- Resolution set to fixed
- Status changed from assigned to closed
We've switched, I'm not planning to do any changes to the coverage tools this month, so it's time to close out this ticket.
I spent some time today looking at coverage.py, and it looks great. I've got a rough conversion of our existing Makefile targets and report-generation tools in my sandbox. The HTML format is prettier than figleaf, but I still need to customize it a bunch to get a report that contains lines-uncovered (which I think is much more meaningful than lines-covered, or percentage-covered).
But yeah, coverage.py looks good. I'll implement the switch soon.