deleting nameless file confounds webish.py

[arch_o_median]

I tried to upload a (non) file to the Test Grid. I clicked upload file on the web interface to my client node when the upload field was empty. This resulted in the following Stack Trace:

/usr/lib/python2.5/site-packages/allmydata/webish.py, line 515 in renderHTTP
513

        elif t == "delete":

514

            if not name:

515

                raise RuntimeError("delete requires a name")

516

            d = self._node.delete(name)

Locals
name	''
self	<allmydata.webish.POSTHandler object at 0x8a8988c>
t	'dele

<type 'exceptions.RuntimeError'>: delete requires a name

[arch_o_median]

Replying to arch_o_median:

I tried to upload a (non) file to the Test Grid. I clicked upload file on the web interface to my client node when the upload field was empty. When I noticed I had uploaded a nameless nothing, I tried to delete it by pressing the "Del" button. This resulted in the following Stack Trace:

/usr/lib/python2.5/site-packages/allmydata/webish.py, line 515 in renderHTTP 513

elif t == "delete":

514

if not name:

515

raise RuntimeError?("delete requires a name")

516

d = self._node.delete(name)

Locals name self <allmydata.webish.POSTHandler object at 0x8a8988c> t 'delete'

<type 'exceptions.RuntimeError?'>: delete requires a name

[zooko]

fixing formatting

[arch_o_median]

CORRECTION: I caused the error by attempting to _delete_ empty-string-named file, _not_ by uploading it as previously (mis)stated.

[warner]

hm, good point. We should catch and ignore (possibly with some sort of admonition to "don't do that") that case.

[warner]

I've fixed webish.py to allow you to delete empty-named files. I also changed it to prohibit you from creating them in the first place.. if you really want to do confusing stuff like that, you'll have to use the PUT api to do it :). But this change will let you clean up the results without getting exceptions.