#1195 closed defect (fixed)
refactor get_disk_stats() and get_available_space()
| Reported by: | zooko | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.0 |
| Component: | code-storage | Version: | 1.8β |
| Keywords: | pyutil cleanup | Cc: | |
| Launchpad Bug: |
Description
Move get_disk_stats() and get_available() space into fileutil.
Attachments (1)
Change History (10)
comment:1 Changed at 2010-09-10T18:56:45Z by zooko
- Keywords review-needed added
Changed at 2010-09-10T18:58:09Z by zooko
comment:2 Changed at 2010-09-11T00:25:12Z by davidsarah
- Keywords reviewed added; review-needed removed
comment:3 Changed at 2010-10-14T04:37:23Z by davidsarah
- Milestone changed from soon to 1.9.0
comment:4 Changed at 2010-10-14T04:55:56Z by davidsarah
- Keywords cleanup added
comment:5 Changed at 2010-10-18T02:41:04Z by zooko
See also #47
comment:6 Changed at 2010-12-31T21:02:18Z by david-sarah@…
In 0da10d4c373eae19:
comment:7 Changed at 2010-12-31T21:05:08Z by davidsarah
- Resolution set to fixed
- Status changed from new to closed
Applied in d5e71c29408bab67 and 123a1a3f04e046fa, and adjusted to leave 512 MiB free in 0da10d4c373eae19. (The latter will only cause additional test-skips on filesystems that have between 4 and 4.5 GiB free.)
comment:8 Changed at 2010-12-31T21:28:33Z by davidsarah
Note that these patches change where the call to
win32api.SetErrorMode(win32con.SEM_FAILCRITICALERRORS |
win32con.SEM_NOOPENFILEERRORBOX)
occurs. Previously that was called when src/allmydata/storage/server.py was imported; now it is called when src/allmydata/util/fileutil.py is imported. It is a good idea to make this call early in the execution of all Windows server or non-GUI software, so #1274 is going to move it to src/allmydata/windows/fixups.py (which is also a more predictable and debuggable place in case there are any problems with it).
comment:9 Changed at 2010-12-31T22:04:09Z by davidsarah
- Keywords reviewed removed
Looks good.