#1344 closed defect (fixed)
'make check' should run tests
| Reported by: | davidsarah | Owned by: | zooko |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.0 |
| Component: | packaging | Version: | 1.8.1 |
| Keywords: | Makefile test reviewed easy | Cc: | |
| Launchpad Bug: |
Description
{{make check}} is a Gnu'ish convention for how to run tests. It should probably map to make test.
Attachments (1)
Change History (8)
Changed at 2011-01-29T17:38:10Z by davidsarah
comment:1 Changed at 2011-01-29T17:52:14Z by davidsarah
- Keywords review-needed added
- Owner changed from somebody to warner
comment:2 Changed at 2011-01-30T05:54:45Z by davidsarah
- Milestone changed from 1.8.2 to 1.9.0
Not needed for 1.8.2.
comment:3 Changed at 2011-06-04T01:19:30Z by zooko
- Keywords easy added
Easy review for somebody! http://tahoe-lafs.org/trac/tahoe-lafs/wiki/PatchReviewProcess
comment:4 Changed at 2011-06-07T00:33:51Z by terrell
- Owner changed from warner to terrell
- Status changed from new to assigned
comment:5 Changed at 2011-06-07T00:59:46Z by terrell
- Keywords reviewed added; review-needed removed
- Owner changed from terrell to zooko
- Status changed from assigned to new
i've reviewed this short patch and this ticket can be closed with patch applied.
before patch:
[08:32:09:trel:~/Desktop/tahoestuff/tahoefromdarcs] make check make: *** No rule to make target `check'. Stop.
after patch: tests are run
comment:6 Changed at 2011-06-23T21:16:41Z by david-sarah@…
- Resolution set to fixed
- Status changed from new to closed
In 082731f45b5bda05:
comment:7 Changed at 2011-06-23T21:17:03Z by zooko
Thanks, david-sarah and terrell!
Note: See
TracTickets for help on using
tickets.
Makefile: add 'make check' as an alias for 'make test'. Also remove an unnecessary dependency of 'test' on 'build' and 'src/allmydata/_version.py'. refs #1344