Opened at 2011-07-12T23:56:56Z
Closed at 2011-07-13T00:04:03Z
#1428 closed defect (invalid)
web-API: rename should use POST, not GET
| Reported by: | davidsarah | Owned by: | davidsarah |
|---|---|---|---|
| Priority: | major | Milestone: | 1.9.0 |
| Component: | code-frontend-web | Version: | 1.8.2 |
| Keywords: | http standards security forward-compatibility backward-compatibility | Cc: | |
| Launchpad Bug: |
Description
The 'rename' button in WUI directory listings uses GET; it should use POST because it has side effects.
If we were to immediately remove the support in the web-API for doing a rename using GET, there would be a compatibility problem with old clients connecting to a new gateway. But we need to remove the support in order to conform to the HTTP spec, and to make browser clients do the right thing (for example they should not resubmit a rename request without user confirmation, because it's not idempotent).
So, let's do this in two steps:
- in v1.9.0, add support for rename using POST and make the WUI use that support
- later, remove support for rename using GET.
Change History (2)
comment:1 Changed at 2011-07-12T23:58:56Z by davidsarah
comment:2 Changed at 2011-07-13T00:04:03Z by davidsarah
- Resolution set to invalid
- Status changed from new to closed
Oh, I'm wrong. The 'rename' button only gets you to the rename form, it doesn't actually rename anything.
Note: See
TracTickets for help on using
tickets.
Similar to #324, but not quite the same issue.