#1446 closed defect (fixed)

SFTP: the lines of the shell session error and df output should end in CRLF

Reported by: davidsarah Owned by: davidsarah
Priority: minor Milestone: 1.9.0
Component: code-frontend Version: 1.8.2
Keywords: sftp error Cc:
Launchpad Bug:

Description

Current result of attempting a shell session to the SFTP frontend:

$ ssh -p 8022 davidsarah@127.0.0.1
davidsarah@127.0.0.1's password: 
This server supports only SFTP, not shell sessions.
                                                   Connection to 127.0.0.1 closed.

Expected result:

$ ssh -p 8022 davidsarah@127.0.0.1
davidsarah@127.0.0.1's password: 
This server supports only SFTP, not shell sessions.
Connection to 127.0.0.1 closed.

Attachments (1)

fix-and-test-1446.darcs.patch (18.8 KB) - added by davidsarah at 2011-07-26T22:03:30Z.
SFTP: Make the lines of the shell session error and the df output end in CRLF. fixes #1446

Download all attachments as: .zip

Change History (5)

Changed at 2011-07-26T22:03:30Z by davidsarah

SFTP: Make the lines of the shell session error and the df output end in CRLF. fixes #1446

comment:1 Changed at 2011-07-26T22:05:10Z by davidsarah

  • Keywords review-needed added

I manually checked that the new df output is still accepted by sshfs and OpenSSH's sftp.

comment:2 Changed at 2011-07-29T00:29:13Z by kevan

  • Owner set to kevan
  • Status changed from new to assigned

comment:3 Changed at 2011-07-29T22:06:28Z by kevan

  • Keywords review-needed removed
  • Owner changed from kevan to davidsarah
  • Status changed from assigned to new

I posted my review comments in comment 10 of #1442, since the patch attached to that ticket also included the patch to this ticket.

comment:4 Changed at 2011-07-30T03:08:20Z by david-sarah@…

  • Resolution set to fixed
  • Status changed from new to closed

In a2699ea6f635c992:

SFTP: write an error message to standard error for unrecognized shell commands. Change the existing message for shell sessions to be written to standard error, and refactor some duplicated code. Also change the lines of the error messages to end in CRLF, and take into account Kevan's review comments. fixes #1442, #1446

Note: See TracTickets for help on using tickets.