#1520 closed defect (fixed)

Assertions in storage/mutable.py provide assurance that the struct library performs correct size transforms

Reported by: zancas Owned by: nobody
Priority: major Milestone: 1.9.0
Component: code-storage Version: 1.9.0a1
Keywords: code mutable Cc:
Launchpad Bug:

Description

The assert statements at the top of this module are intended to provide assurance that the correct size is indicated by the arguments to the various struct methods used by the mutable file. A syntax error was preventing the intended function of these asserts. The attached patch corrects that syntax and provides the desired assurance.

In particular the relevant '>' format character is inserted in the assertion, and the statement is converted into a comparison with '=='.

Attachments (1)

fixedmutableasserts.darcs.patch (8.3 KB) - added by zancas at 2011-09-01T08:54:00Z.

Download all attachments as: .zip

Change History (2)

Changed at 2011-09-01T08:54:00Z by zancas

comment:1 Changed at 2011-09-01T16:07:59Z by warner

  • Component changed from unknown to code-storage
  • Milestone changed from undecided to 1.9.0
  • Resolution set to fixed
  • Status changed from new to closed

looks good! landed in d2e5de3b6913082f, with some additional improvements (emit the failing size) in 01b5124d0af5e6fe. thanks!

Note: See TracTickets for help on using tickets.