Opened at 2011-09-05T02:09:02Z

Closed at 2011-09-06T18:34:13Z

Last modified at 2011-09-06T18:39:26Z

#1527 closed defect (fixed)

CLI: make the --mutable-type option value for 'tahoe put' and 'tahoe mkdir' case-insensitive

Reported by: davidsarah Owned by: davidsarah
Priority: minor Milestone: 1.9.0
Component: code-frontend-cli Version: 1.9.0a1
Keywords: tahoe-put tahoe-mkdir usability Cc:
Launchpad Bug:

Description

The docs always use uppercase for SDMF and MDMF, so --mutable-type should accept these in uppercase.

Attachments (1)

mutable-type-case-insenstive.darcs.patch​ (58.1 KB) - added by davidsarah at 2011-09-05T02:12:23Z.
CLI: make the --mutable-type option value for 'tahoe put' and 'tahoe mkdir' case-insensitive, and change --help for these commands accordingly. fixes #1527

Download all attachments as: .zip

Change History (8)

Changed at 2011-09-05T02:12:23Z by davidsarah

CLI: make the --mutable-type option value for 'tahoe put' and 'tahoe mkdir' case-insensitive, and change --help for these commands accordingly. fixes #1527

comment:1 Changed at 2011-09-05T02:13:49Z by davidsarah

  • Keywords review-needed added
  • Owner changed from davidsarah to kevan

The patch also includes a minor code simplification in tahoe_put.py.

comment:2 Changed at 2011-09-05T02:16:19Z by davidsarah

Note that the change of the default for --mutable-type from False to None just suppresses an unhelpful "[default: False]" in the help synopsis, and has no other effect.

comment:3 follow-up: Changed at 2011-09-05T18:18:34Z by kevan

  • Keywords review-needed removed
  • Owner changed from kevan to davidsarah

Can you add tests for --mutable-type=SDMF and --mutable-type=mdmf to Mkdir.test_mkdir_mutable_type?

Looks good, otherwise.

comment:4 in reply to: ↑ 3 Changed at 2011-09-05T23:51:04Z by davidsarah

  • Status changed from new to assigned

Replying to kevan:

Can you add tests for --mutable-type=SDMF and --mutable-type=mdmf to Mkdir.test_mkdir_mutable_type?

Yes, I'll do that tomorrow.

comment:5 Changed at 2011-09-06T18:34:13Z by david-sarah@…

  • Resolution set to fixed
  • Status changed from assigned to closed

In 23f46b758ecb3942:

(The changeset message doesn't reference this ticket)

comment:6 Changed at 2011-09-06T18:34:14Z by david-sarah@…

In 1e59930fda64428f:

CLI: improve test for 'tahoe mkdir --mutable-type='. refs #1527

comment:7 Changed at 2011-09-06T18:39:26Z by david-sarah@…

In 6b97e6f40720bbe4:

CLI: test_cli.py -- remove an unnecessary call in test_mkdir_mutable_type. refs #1527

Note: See TracTickets for help on using tickets.