separate configuration from instantiation of Client instance

[zooko]

I'm writing tests of configuration, and currently reading values from the configuration and using them is done inside the constructor of Client​. I would rather there be some separate code that reads the values from configuration and does whatever validation and parsing is necessary and then passes all configuration options as arguments to the constructor of the class. This would be as prescribed in the CodingStandards document.

[zooko]

Here is a patch to rename Client to ClientAndServer and to put a little shim into place so that .tac files can continue invoking allmydata.client.Client.

[davidsarah]

attachment:renameClient.dpatch​ causes this test failure (looks like just a missing rename):

[ERROR]: allmydata.test.test_upload

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/twisted/trial/runner.py", line 584, in loadPackage
    module = modinfo.load()
  File "/usr/lib/python2.6/dist-packages/twisted/python/modules.py", line 383, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 464, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python2.6/dist-packages/twisted/python/reflect.py", line 400, in _importAndCheckStack
    return __import__(importName)
  File "/home/davidsarah/tahoe/ticket999-S3-backend/src/allmydata/test/test_upload.py", line 186, in <module>
    class FakeClient:
  File "/home/davidsarah/tahoe/ticket999-S3-backend/src/allmydata/test/test_upload.py", line 209, in FakeClient
    _secret_holder = client.SecretHolder("lease secret", "convergence secret")
exceptions.AttributeError: 'module' object has no attribute 'SecretHolder'
-------------------------------------------------------------------------------

[davidsarah]

test/test_upload.py: fix a missing rename of client to clientandserver. refs #1548 (Includes previous patch.)

[zooko]

Hm, what's the status of this patch? Is it ready for code review?

[daira]

I'd forgotten all about this ticket. The patch will need redoing for git, but I approve in principle of making this change after 1.11.

[warner]

Milestone renamed

[warner]

renaming milestone

[exarkun]

Moving open issues out of closed milestones.

[meejah]

Ticket retargeted after milestone closed