Patch to add a favicon to the web UI

[marcusw]

I came up with a small (almost trivial) ​git branch to add ​a favicon to the web UI. More information is available at the ​commit page on github.

[davidsarah]

I reviewed the XHTML changes on the ​git branch and they look good. I confirmed that those are all the XHTML files that need to be changed. I also like the favicon (if we're staying with Kevin Reid's icon more generally).

​CC BY 3.0 Unported is ​not compatible with GPL, primarily because of the attribution requirement. (I hate acting the part of license compatibility enforcer, but care about getting updates to Tahoe-LAFS into distributions like Debian that are strict about that.) This probably means that Kevin Reid's icon needs to be relicensed, so that the derived favicon can be.

[marcusw]

I was afraid of the licensing issues and totally understand (hence the long-winded git comment). Bad things happen to projects with sloppy copyright. Have you contacted kreid about relicensing?

If he agrees, you've got the go-ahead from me to relicense my derivative (the 16x16 icon) under whatever conditions he chooses.

[zooko]

Dear Kevin: may we please have permission to use your Tahoe-LAFS logo contributions under the same licences as Tahoe-LAFS itself? Actually, would you mind granting the Tahoe-LAFS Software Foundation permission to use it however that entity sees fit, with little or no restriction? Thank you!

(The reason we're asking is to include a favicon derived from your logo in the Tahoe-LAFS distribution to include in the WUI.)

[kpreid]

I hereby give permission for my Tahoe logo designs and SVG files (all material at ​http://switchb.org/kpreid/2009/tahoe/ ) to reused, modified, and distributed under the same license(s) as Tahoe-LAFS itself, including any future relicensing or other such change which the developer community has consensus upon.

[marcusw]

Any idea when/whether this will be landed?

[zooko]

I removed the licensing keyword. Thanks, Kevin! I don't see either a review-needed keyword or a reviewed keyword so I can't tell instantly what state this ticket is in. Someone please push this ticket further along! ​https://tahoe-lafs.org/trac/tahoe-lafs/wiki/PatchReviewProcess

[davidsarah]

marcusw: your changes are still under the license at ​https://github.com/marcuswanner/tahoe-lafs/commit/b3ee8882f0819cab0efdcf1b7620bc9c74b2ff2f . You need to relax that license, as kpreid did.

[marcusw]

I hereby give permission for my Tahoe logo designs and SVG files previously referenced in this ticket and that git commit message to be reused, modified, and distributed under the same license(s) as Tahoe-LAFS itself, including any future relicensing or other such change which the developer community has consensus upon. This release is in addition to the one on the git branch message.

The same applies to the files linked to in ​https://tahoe-lafs.org/trac/tahoe-lafs/ticket/1185#comment:16

[davidsarah]

Thanks. Reviewing.

[davidsarah]

Oh, I already reviewed it in comment:1. OK, I'll land this now.

[david-sarah@…]

In 054374400e28cb00:

Marcus Wanner's favicon patch. fixes #1592

[davidsarah]

I added some tests in 531f562fcfcb7b68. Review needed for those, and also for a cleanup patch 4618571389c62d2f.

[zooko]

Reviewed 4618571389c62d2f and 531f562fcfcb7b68.