Opened at 2012-06-23T23:39:18Z

Closed at 2013-03-23T18:07:20Z

Last modified at 2013-03-23T18:07:59Z

#1781 closed defect (fixed)

default maximum-immutable-share-size is probably off-by-one

Reported by: davidsarah Owned by: warner
Priority: minor Milestone: 1.10.0
Component: code Version: 1.9.1
Keywords: immutable easy Cc:
Launchpad Bug:

Description (last modified by davidsarah)

At src/allmydata/storage_client.py#L181​: 

"maximum-immutable-share-size": 2**32,

I think this is the default used for old servers that didn't explicitly declare a maximum immutable share size, and that it should really be 232 - 1.

Change History (7)

comment:1 Changed at 2012-06-23T23:39:37Z by davidsarah

  • Description modified (diff)

comment:2 Changed at 2013-03-21T00:12:53Z by warner

  • Milestone changed from 1.10.0 to 1.11.0

I agree. I'm going to change it after we release 1.10.

comment:3 Changed at 2013-03-23T02:41:28Z by davidsarah

  • Keywords easy added

If we agree this change is correct, it can't hurt to change it now, right? It seems to have very low regression risk.

comment:4 Changed at 2013-03-23T03:12:46Z by davidsarah

  • Keywords review-needed added

​https://github.com/davidsarah/tahoe-lafs/commit/1781-maximum-immutable-share-size

Does this need a test?

comment:5 Changed at 2013-03-23T03:13:50Z by davidsarah

  • Owner set to warner

comment:6 Changed at 2013-03-23T18:07:20Z by David-Sarah Hopwood <david-sarah@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 68b7f9e979158dcb:

Correct off-by-one in maximum-immutable-share-size for old servers. fixes #1781

Signed-off-by: David-Sarah Hopwood <david-sarah@…>

comment:7 Changed at 2013-03-23T18:07:59Z by warner

  • Keywords review-needed removed
  • Milestone changed from 1.11.0 to 1.10.0

nope, no test needed. I've landed it for 1.10. Thanks!

Note: See TracTickets for help on using tickets.