#2704 new defect

remove _lsLine from sftpd.py

Reported by: leif Owned by: daira
Priority: normal Milestone: undecided
Component: code-frontend-ftp-sftp Version: 1.10.2
Keywords: cleanup sftp Cc:
Launchpad Bug:


The _lsLine function in src/allmydata/frontends/sftpd.py was copied from Twisted and has a comment mentioning that after Twisted 8.2 is/was released we should use the Twisted version instead. Twisted's version of the function has changed significantly since then; we should make sure the new one works and then remove this from the Tahoe-LAFS code.

Change History (2)

comment:1 Changed at 2016-08-07T17:54:36Z by warner

  • Component changed from unknown to code-frontend-ftp-sftp

comment:2 Changed at 2020-01-17T16:30:13Z by exarkun

The functions have diverged sufficiently now that it's not a simple replacement. It seems like this might still be a good idea but someone will have to read both functions carefully and figure out if they are still basically accomplishing the same thing or not.

Note: See TracTickets for help on using tickets.