Opened at 2018-09-04T20:50:02Z
Last modified at 2020-01-21T20:41:06Z
#2946 new enhancement
pass reactor as an argument to allmydata.test.test_node.testing_tub
| Reported by: | meejah | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | code | Version: | 1.12.1 |
| Keywords: | refactor | Cc: | |
| Launchpad Bug: |
Description
It is a better Twisted practice to pass in a "reactor" argument to any functions that need one (instead of importing it). Tahoe-LAFS should follow this practice.
Change History (3)
comment:1 Changed at 2018-09-06T18:37:34Z by meejah
comment:2 Changed at 2020-01-21T20:40:47Z by exarkun
- Summary changed from pass reactor as an argument to pass reactor as an argument to allmydata.test.test_node.testing_tub
comment:3 Changed at 2020-01-21T20:41:06Z by exarkun
Narrowed the focus of this issue to the one API mentioned. All should eventually be fixed but likely not at the same time.
Note: See
TracTickets for help on using
tickets.
allmydata.test.test_node has testing_tub that should get a reactor arg.