Opened at 2022-03-09T17:53:45Z
Closed at 2023-04-12T21:01:02Z
#3880 closed enhancement (fixed)
Add logging to HTTP storage protocol, part 1
| Reported by: | itamarst | Owned by: | GitHub <noreply@…> |
|---|---|---|---|
| Priority: | normal | Milestone: | HTTP Storage Protocol |
| Component: | unknown | Version: | n/a |
| Keywords: | Cc: | ||
| Launchpad Bug: |
Description
Probably want some logging of what's going on, via Eliot.
Change History (6)
comment:1 Changed at 2022-05-04T14:10:31Z by itamarst
comment:2 Changed at 2022-08-08T14:15:38Z by itamarst
Beyond Twisted release, there is also the bigger-picture question of what logging system to use. Some options:
- Eliot: tracing, so much better for distributed systems and complex logging.
- OpenTelemetry?: like Eliot, but with vastly bigger ecosystem, and ability to do cross-language (and with some work, probably cross-FFI?) tracing. API is not as nice as Eliot, I believe, but that can be fixed with a wrapper.
- Straight-line logging library. I find these inadequate, personally, but they do make code look cleaner since there's less indentation.
comment:3 Changed at 2022-09-14T12:00:26Z by itamarst
So Twisted has been released with this fix.
But, there's still the question of whether to use Eliot...
comment:4 Changed at 2023-04-03T15:34:50Z by itamarst
Decided to use Eliot since it's already there and being used.
comment:5 Changed at 2023-04-03T15:35:00Z by itamarst
- Summary changed from Add logging to HTTP storage protocol to Add logging to HTTP storage protocol, part 1
comment:6 Changed at 2023-04-12T21:01:02Z by GitHub <noreply@…>
- Owner set to GitHub <noreply@…>
- Resolution set to fixed
- Status changed from new to closed
In 1746091/trunk:
Note: See
TracTickets for help on using
tickets.
There is a branch with start of code, but it is blocked on https://github.com/twisted/twisted/pull/1690 being merged and then a Twisted release coming out with it. Lacking that fix, Eliot blows up.