Opened at 2023-01-31T17:10:12Z

Closed at 2023-03-16T12:26:08Z

#3970 closed enhancement (fixed)

Type Annotations and updating of function for wormholetesting

Reported by: daniellee Owned by: daniellee
Priority: minor Milestone: User Documentation Goals
Component: unknown Version: n/a
Keywords: Type Annotations Cc:
Launchpad Bug:

Description (last modified by daniellee)

While using mypy with the --strict flag to type annotate the wormholetesting.py file I encountered a function that should be updated in this file and I thought it might be a good place to start.

Function in question: _verify() function uses a deprecated function getargspec(). We aim to update this function to use the new getfullargspec() and yet maintain the strictness of the check.

TODO:

  1. Update _verify() function.
  2. Type annotate functions.

Change History (8)

comment:1 Changed at 2023-01-31T17:14:50Z by daniellee

  • Description modified (diff)

comment:2 Changed at 2023-01-31T17:15:03Z by daniellee

  • Owner set to daniellee
  • Status changed from new to assigned

comment:3 Changed at 2023-01-31T17:15:16Z by daniellee

  • Description modified (diff)

comment:4 Changed at 2023-02-07T16:43:19Z by daniellee

  • Description modified (diff)
  • Summary changed from Type Annotations for wormhole and jsonbytes to Type Annotations for wormholetesting

comment:5 Changed at 2023-02-17T22:34:39Z by daniellee

  • Description modified (diff)

comment:6 Changed at 2023-02-17T22:34:56Z by daniellee

  • Summary changed from Type Annotations for wormholetesting to Type Annotations and refactoring for wormholetesting

comment:7 Changed at 2023-02-21T18:50:45Z by daniellee

  • Description modified (diff)
  • Summary changed from Type Annotations and refactoring for wormholetesting to Type Annotations and updating of function for wormholetesting

comment:8 Changed at 2023-03-16T12:26:08Z by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 8431bbf/trunk:

Merge pull request #1261 from danielzwlee/3970.type-annotations-clean

Fixes: ticket:3970

Note: See TracTickets for help on using tickets.