#580 new defect

repairer: upload fresh shares to replace corrupted shares

Reported by: zooko Owned by:
Priority: major Milestone: soon
Component: code-storage Version: 1.2.0
Keywords: repair preservation anti-censorship Cc:
Launchpad Bug:


The current repairer just uses the normal upload code, so if a server is serving a corrupted share but it doesn't realize that its share is corrupted, then when the uploader contacts the server to offer to upload shares, the server will say 'Yep! Already got a share of that file!' and the uploader will believe him and not bother to upload that share anywhere else. Therefore, the current repairer doesn't repair corrupted shares, only missing ones.

Change History (7)

comment:1 Changed at 2010-03-25T01:52:15Z by davidsarah

  • Keywords repair preservation added
  • Milestone changed from undecided to 1.7.0
  • Priority changed from major to critical

Yikes, I wasn't aware of this.

comment:2 Changed at 2010-06-16T03:58:16Z by davidsarah

  • Milestone changed from 1.7.0 to 1.7.1

comment:3 Changed at 2010-07-10T18:50:42Z by zooko

  • Milestone changed from 1.7.1 to soon

comment:4 Changed at 2010-12-16T01:13:43Z by davidsarah

  • Keywords anti-censorship added

comment:5 Changed at 2012-11-13T23:26:08Z by zooko

  • Priority changed from critical to normal

comment:6 Changed at 2012-11-14T03:09:39Z by davidsarah

  • Priority changed from normal to major

Major because it could cause data loss.

comment:7 Changed at 2013-04-29T20:51:01Z by daira

  • Milestone changed from soon to 1.11.0

Since we're revisiting how repair works in 1.11, I think that in that version, --repair should imply --verify for tahoe [deep-]check.

Note: See TracTickets for help on using tickets.