string exception raised to web renderer?

[zooko]

In the twistd.log of allmydata.com user gar5 I find this exception:

2009-06-16 14:50:04+0000 [Negotiation,client] Exception rendering error page:
2009-06-16 14:50:04+0000 [Negotiation,client] Unhandled Error
        Traceback (most recent call last):
          File "/usr/local/src/TahoeFS/allmydata-tahoe-1.4.1/Twisted-8.2.0-py2.4-linux-i686.egg/twisted/internet/defer.py", line 328, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File "/usr/local/src/TahoeFS/allmydata-tahoe-1.4.1/Twisted-8.2.0-py2.4-linux-i686.egg/twisted/internet/defer.py", line 289, in _continue
            self.unpause()
          File "/usr/local/src/TahoeFS/allmydata-tahoe-1.4.1/Twisted-8.2.0-py2.4-linux-i686.egg/twisted/internet/defer.py", line 285, in unpause
            self._runCallbacks()
          File "/usr/local/src/TahoeFS/allmydata-tahoe-1.4.1/Twisted-8.2.0-py2.4-linux-i686.egg/twisted/internet/defer.py", line 328, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
        --- <exception caught here> ---
          File "/usr/lib/python2.4/site-packages/Nevow-0.9.33_r17222-py2.4.egg/nevow/appserver.py", line 82, in processingFailed
            handler.renderHTTP_exception(ctx, reason)
          File "/usr/lib/python2.4/site-packages/allmydata_tahoe-1.4.1-py2.4.egg/allmydata/web/common.py", line 173, in renderHTTP_exception
            text, code = humanize_failure(f)
          File "/usr/lib/python2.4/site-packages/allmydata_tahoe-1.4.1-py2.4.egg/allmydata/web/common.py", line 127, in humanize_failure
            got = f.value.got
        exceptions.AttributeError: 'str' object has no attribute 'got'
        
2009-06-16 14:50:05+0000 [Negotiation,client] 'Original exception:'
2009-06-16 14:50:05+0000 [Negotiation,client] Unhandled Error
        Traceback from remote host -- Traceback (most recent call last):
          File "/usr/lib/python2.5/site-packages/foolscap/call.py", line 667, in _done
            self.request.complete(res)
          File "/usr/lib/python2.5/site-packages/foolscap/call.py", line 53, in complete
            self.deferred.callback(res)
          File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py", line 239, in callback
            self._startRunCallbacks(result)
          File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py", line 304, in _startRunCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/usr/lib/python2.5/site-packages/twisted/internet/defer.py", line 317, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File "/usr/lib/python2.5/site-packages/allmydata/immutable/upload.py", line 379, in _got_response
            return self._loop()
          File "/usr/lib/python2.5/site-packages/allmydata/immutable/upload.py", line 302, in _loop
            self.shares_of_happiness)
        allmydata.interfaces.NotEnoughSharesError: peer selection failed for <Tahoe2PeerSelector for upload bdzm5>: placed 0 shares out of 10 total (10 homeless), sent 104 quer
ies to 104 peers, 0 queries placed some shares, 104 placed none, got 0 errors
        

[zooko]

Oh, this may be the same issue as #808 (AttributeError: TahoeError instance has no attribute 'args'). It occurred at about the same time for the same user. I suspect #808 is the cli version of this bug and this ticket is the wui version of this bug.

[zooko]

Oh, this is not a security issue after all, since the string doesn't get rendered. Right, daira?

[daira]

Right, it's just a non-security-relevant error-reporting bug, I think.